Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kill switches in poke #9336

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Dec 12, 2024

Description

Adds a kill switch setup to poke. For now these kill switches don't do anything.

Screenshot 2024-12-12 at 17 05 30

Risk

Migration

Deploy Plan

Apply migration then deploy front

@fontanierh fontanierh requested a review from spolu December 12, 2024 16:06
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

});

return new Ok(this.id);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no toJSON() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abstract delete(
auth: Authenticator,
{ transaction }: { transaction?: Transaction }
): Promise<Result<undefined | number, Error>>;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that this is abstract method is required btw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see what you meant now. Not sure it's useful since we just want to return strings

@fontanierh fontanierh force-pushed the feat/poke-kill-switch-setup branch from 45d8422 to 014d6ce Compare December 13, 2024 10:07
@fontanierh fontanierh merged commit fc9ece6 into main Dec 13, 2024
7 checks passed
@fontanierh fontanierh deleted the feat/poke-kill-switch-setup branch December 13, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants