Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors] update Confluence to use new internalIDs in content nodes and upsertions #9337

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

aubin-tchoi
Copy link
Contributor

@aubin-tchoi aubin-tchoi commented Dec 12, 2024

Description

  • This PR aims at moving the Confluence connector to use the new internalIds (the ones with confluence-page- or confluence-space-) in both the content nodes and the upsertions.
  • Tested locally:
    • we get the correct ID in the data_source_view when running this new version.
    • if we create the data_source_view with the old version of connectors then we don't see nodes in the AssistantBuilder.
    • applying the migration script turns the data_source_view we get when running the old version of connectors into the one we get when running the new one.

Risk

  • everything is logged, missteps will be painful but recoverable

Deploy Plan

  • Use the new button to stop (TBD)
  • Deploy connectors
  • Shortly after run migrations that changes agent configurations

@aubin-tchoi aubin-tchoi force-pushed the confluence-newid-content-nodes branch from 49d6f78 to d7eb452 Compare December 12, 2024 21:08
@aubin-tchoi aubin-tchoi self-assigned this Dec 13, 2024
@aubin-tchoi aubin-tchoi requested a review from spolu December 13, 2024 08:59
@aubin-tchoi aubin-tchoi changed the title [connectors] update Confluence to use new itnernalIDs in content nodes and upsertions [connectors] update Confluence to use new internalIDs in content nodes and upsertions Dec 13, 2024
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay Looks very reasonable

@aubin-tchoi aubin-tchoi merged commit 47c8f03 into main Dec 13, 2024
10 checks passed
@aubin-tchoi aubin-tchoi deleted the confluence-newid-content-nodes branch December 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants