[sparkle] - refacto: deprecate citation #9342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesBelveze
force-pushed
the
sparkle/deprecate-citation
branch
from
69fe3b8 to
a035385
Compare
|
layout is broken in compact (ConversationMessage story)
|
|
@tdraier The layout wasn't actually set to compact.. Should be fine now 👌🏼 |
tdraier
approved these changes
Dec 14, 2024
…ure and remove CitationNew - Refactored Citation component to be more modular, introducing subcomponents for better readability and maintenance - Removed the now redundant CitationNew component and related stories in favor of the updated Citation structure - Streamlined and condensed citation components into a more cohesive and manageable set of subcomponents - Simplified the usage of Citation components in stories by using the new subcomponent architecture - Updated class names and ordering for better consistency and to follow naming conventions [src/stories] - refactor: update stories to reflect changes in Citation components - Adapted Citation stories to utilize the new subcomponents introduced in the Citation refactor - Removed CitationNew stories as the component has been deprecated and merged with Citation [src/components/Sheet.tsx] - fix: adjust shadow-tale-white order for sheet header style - Modified the ordering of class names to adhere to styling conventions and ensure visual consistency [src/components] - cleanup: remove deprecated export of CitationNew component - Removed the export statement for the now-nonexistent CitationNew component after its deprecation and merge into Citation
- Deleted the ZoomableImageCitationWrapper to simplify the image citation features - Removed the component export from the main index to clean up unused code references
- Replace individual Citation components with a more flexible structure including CitationIcons and CitationTitle - Remove usage of ZoomableImageCitationWrapper in favor of a unified Citation component structure
…edCitationsGrid - Remove the display name assignment for CitationImage component - Restructure Citation items to use composition rather than props in PaginatedCitationsGrid - Replace CitationType with icon JSX element for flexibility in citation rendering - Update storybook for PaginatedCitationsGrid with the new component design and DocumentIcon usage
- Change padding specificity from general to horizontal for small, medium, and large sizes - Adjust the button alignment to center justify within its container
…omponent - Introduced a 'compact' size property to reduce the visual space taken by agent messages in conversations
- Update `package-lock.json` and `package.json` to reflect the new package version - Ensure dependencies are aligned with the upgraded version
JulesBelveze
force-pushed
the
sparkle/deprecate-citation
branch
from
d3a33f0 to
a7e0b13
Compare
…ConversationMessageContent - Removed fixed grid column classes and added responsive grid classes to support various screen sizes - Included new container utility class to enhance structure in conversation message layouts
…geContent - Change the grid column setup at 'xs' breakpoint to start with 2 columns instead of 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the old
Citationcomponent to renameCitationNew->CitationRisk
Low, breaking UI
Deploy Plan