Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedbacks builder UI sparkle #9368

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

feedbacks builder UI sparkle #9368

wants to merge 20 commits into from
+733 −144

Conversation

overmode
Copy link
Contributor

@overmode overmode commented Dec 13, 2024 •
edited
Loading

Description

Showing feedbacks for builders
Co-PR with @albandum
Left:

  • New Assistant Builder UI
  • Remove from Manage View
  • Double-check auth compliance with spaces

Risk

Break assistant builder

Deploy Plan

Migrate Feedback model, deploy Front

albandum and others added 19 commits December 3, 2024 17:55
@albandum
Add info/feedback tab
3e46609
@albandum
Committing performance preview
6261f66
Skeleton is here, need to bring the configurations history endpoint
153f771
@overmode
Merge branch 'main' into alban/feedbacks-builder-ui-sparkle
c53813d
Now fetching config history, added conv button need a way to get the …
412c157 
…conv url
Can get conversationsId in the feedback card
f48174c
Fixed link, reordered feedbacks
f88e5ee
Applied Pr comments
5274870
Auth done in endpoint
dcb2e7c
Modified feedback popover to be more transpoarent
4deddff
Using fetchByModelId
849fe4b
Use spinner instead of ? avatar
143ebcf
Now auto-scrolling to messages, fixed tab resetting to info
1c0a48b
Fixed sparkle referencing local repo in package.json
d287999
@overmode
Merge branch 'main' into alban/feedbacks-builder-ui-sparkle
4bf8b1c
Conversation will be shared: warning
f49ef7c
Added auth filtering on feedbacks and improved fk management
70b039c
fixed deletion
ffb865c
More direct fetch in delete method
abfd5f8
@overmode overmode changed the title Alban/feedbacks builder UI sparkle feedbacks builder UI sparkle Dec 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Fails
🚫

Files in **/models/ have been modified. Addition and deletion should be in 2 separate PRs:

  1. Addition: migrate and deploy
  2. Deletion: deploy and migrate

Please add the migration-ack label to acknowledge that a migration will be needed once merged into 'main'.

Generated by 🚫 dangerJS against 65674ca

@overmode overmode mentioned this pull request Dec 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overmode @albandum