Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[front] restore access for webcrawler #9399

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[front] restore access for webcrawler #9399

merged 1 commit into from
Dec 16, 2024

Conversation

tdraier
Copy link
Contributor

@tdraier tdraier commented Dec 16, 2024

Description

Webcrawler is using system key, but system key cannot read custom vaults (only access system/global).

Risk

Deploy Plan

deploy front

@github-actions GitHub Actions
Copy link

Fails
🚫

Files in **/api/v1/ have been modified. Please add the documentation-ack label to acknowlegde that if anything changes
in a public endpoint, you need to edit the JSDoc comment
above the handler definition and/or the swagger_schemas.ts file and regenerate the documentation using npm run docs

Generated by 🚫 dangerJS against 9e6a6c3

Fraggle
Fraggle approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@Fraggle Fraggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, interested in the long term fix.

@tdraier tdraier merged commit 6980516 into main Dec 16, 2024
3 of 4 checks passed
@tdraier tdraier deleted the thomas/webcrawler branch December 16, 2024 10:07
tdraier added a commit that referenced this pull request Dec 16, 2024
@tdraier
Revert "[front] restore access for webcrawler (#9399)"
a2390c9 
This reverts commit 6980516.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fraggle Fraggle Fraggle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdraier @Fraggle