Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TemplateResource to new sIds #9405

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Dec 16, 2024

Description

See: https://app.datadoghq.eu/notebook/194053/agentconfiguration-optimization?notebookType=legacy

Agent configurations retrieval is extremely slow due to a sequential template retrieval on every agent configurations, just to get the sId. Move TemplateResource to using new sIds and save that call.

Risk

Break template related operations.
Tested in dev
Will test on edge first

Deploy Plan

  • deploy front
  • run migration (after deploy)

@spolu spolu requested a review from fontanierh December 16, 2024 10:55
Copy link

github-actions bot commented Dec 16, 2024

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 0bfe8ad

@spolu spolu added the migration-ack 📁 Label to acknowledge that a migration is required. label Dec 16, 2024
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spolu
Copy link
Contributor Author

spolu commented Dec 16, 2024

Tested in both dev and fron-tedge

@spolu spolu merged commit 406003f into main Dec 16, 2024
13 of 14 checks passed
@spolu spolu deleted the spolu-optimize_get_agent_configurations branch December 16, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants