Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.github] - refactor(configs): transition config to .env #9407

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

JulesBelveze
Copy link
Contributor

@JulesBelveze JulesBelveze commented Dec 16, 2024

Description

This PR aims at storing the region dependant build args into .env.* files instead of .yaml files such that variables can directly be loaded without the need for yq

Risk

Deploy Plan

… files

 - Replaced regional yaml configuration files with region-specific .env files
 - Standardized environment variable management across different deployment regions

[k8s] - refactor: update cloudbuild script to read from .env files

 - Removed build-args volume and preparation step that read from yaml files
 - Altered container image building step to read environment variables from new .env files
@JulesBelveze JulesBelveze merged commit a967563 into main Dec 16, 2024
3 checks passed
@JulesBelveze JulesBelveze deleted the fix/workflows/build-args-loading branch December 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant