Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update SQL query condition in parents migrator to use >= for timestamp comparison #9409

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Dec 16, 2024

Description

Several docs within a datasource can have the same timestamp, which means some docs aren't migrated.

Risk

process the same docs more than once

Deploy Plan

re-run migration on affected connectors (at least notion)

Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fontanierh fontanierh force-pushed the fix/parents-migrator-use-ids branch from 175377d to d821c29 Compare December 16, 2024 12:45
@fontanierh fontanierh changed the title fix(parents migrator): use id as the iterator for dsdocs fix: update SQL query condition in parents migrator to use >= for timestamp comparison Dec 16, 2024
@spolu
Copy link
Contributor

spolu commented Dec 16, 2024

Can we skip the work if we detect that the parents are already good?

@fontanierh fontanierh force-pushed the fix/parents-migrator-use-ids branch from 12372a3 to 23fbb36 Compare December 16, 2024 14:27
@fontanierh fontanierh merged commit 0ff3838 into main Dec 16, 2024
3 checks passed
@fontanierh fontanierh deleted the fix/parents-migrator-use-ids branch December 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants