Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: upsertFolder when syncing channel #9489

Merged
merged 3 commits into from
Dec 18, 2024
Merged

slack: upsertFolder when syncing channel #9489

merged 3 commits into from
Dec 18, 2024

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Dec 18, 2024 •
edited
Loading

Description

  • upsertDataSourceFolder for channels in slack connectors at first loop of syncChannel (which is the moment we insert if needed SlackChannel in connector DB)
  • deleteDataSourceFolder when channels are garbage collected

Risk

N/A (tested locally)

Deploy Plan

  • deploy connectors

@spolu spolu requested a review from philipperolet December 18, 2024 13:45
philipperolet
philipperolet reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@philipperolet philipperolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Would recommend merging #9488 then this one to uncomment mimeType

@spolu spolu force-pushed the spolu-slack_folders branch from 32f9749 to b1ff87e Compare December 18, 2024 14:21
@spolu spolu merged commit b02142c into main Dec 18, 2024
3 checks passed
@spolu spolu deleted the spolu-slack_folders branch December 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipperolet philipperolet philipperolet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spolu @philipperolet