Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace o1-preview by o1 #9596

Merged
merged 1 commit into from
Dec 22, 2024
Merged

feat: replace o1-preview by o1 #9596

merged 1 commit into from
Dec 22, 2024

Conversation

fontanierh
Copy link
Contributor

Description

replaces o1-preview by o1.

o1-preview and o1-mini do not support system messages. o1 supports the new developer messages instead of the system messages, so I added support for that.

Risk

N/A

Deploy Plan

Deploy core, deploy front

@fontanierh fontanierh requested review from PopDaph and spolu December 22, 2024 14:49
spolu
spolu approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very reasonable.

Let's make sure that non o1 agents still work properly before merging 👍

@fontanierh
Copy link
Contributor Author

thanks, yeah they do @spolu

@fontanierh fontanierh merged commit 9cdc903 into main Dec 22, 2024
8 checks passed
@fontanierh fontanierh deleted the feat/replace-o1-preview-by-o1 branch December 22, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu approved these changes

@PopDaph PopDaph Awaiting requested review from PopDaph

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontanierh @spolu