Public API/SDK update for /me route to handle extension blacklisted domains. #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PopDaph
commented
Jan 2, 2025
PopDaph
force-pushed
the
extension-blacklist-domains-api
branch
from
a7e70da to
2f833cb
Compare
tdraier
reviewed
Jan 2, 2025
PopDaph
force-pushed
the
extension-blacklist-domains-api
branch
2 times, most recently
from
5c1a305 to
545a1a4
Compare
PopDaph
force-pushed
the
extension-blacklist-domains-api
branch
from
545a1a4 to
b5dfd1c
Compare
tdraier
approved these changes
Jan 2, 2025
flvndvd
reviewed
Jan 2, 2025
| segmentation: w.segmentation || null, | ||
| whiteListedProviders: w.whiteListedProviders, | ||
| defaultEmbeddingProvider: w.defaultEmbeddingProvider, | ||
| ...(populateExtensionConfig && { |
There was a problem hiding this comment.
Can we add a toJSON (to align with other resources) on the ExtensionConfigurationResource and return it instead of accessing property manually?
There was a problem hiding this comment.
I have a toJson() but here I'd rather get the resources since I need to access workspaceId that I don't necessarily want to expose in the type. Also, here I only want to display the blacklistedDomains attribute, I don't want the full type. I can't just spread the type because it also has an id and sId and we don't want to conflict with the workspace.
I could put all that in a sub object with a config key but since the relation is 0-1 I like it flat with the workspace!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes on Front:
WorkspaceTypecan take anextensionBlacklistedDomainsstring array.UserTypeWithWorkspacereturns an attachedWorkspaceTypeinstead ofLightWorkspaceType./meroute accepts a header"X-Request-Origin", if set to extension it will populateextensionBlacklistedDomainsin the response.Changes on Node SDK:
MeResponseSchemaandWorkspaceSchemato match the changes made on front API.Risk
Should be safe as I'm only adding an optional attribute to an existing type.
Deploy Plan
Next
=> Then I can use the updated SDK on the extension to disable the share buttons if the current domain is from a blacklisted domain.