fix(ui): desabled GKE metadata by default. Fixes kubeflow#11247 and k…

…ubeflow#11260 Signed-off-by: Dave Canton <[email protected]>
dvcanton · Nov 23, 2024 · 2c494c6 · 2c494c6
1 parent 2e05b3d
commit 2c494c6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/frontend/server/app.test.ts b/frontend/server/app.test.ts
@@ -188,7 +188,7 @@ describe('UIServer apis', () => {
             ? Promise.resolve({ ok: true, text: () => Promise.resolve('test-cluster') })
             : Promise.reject('Unexpected request'),
         );
-        app = new UIServer(loadConfigs(argv, {}));
+        app = new UIServer(loadConfigs(argv, { DISABLE_GKE_METADATA: 'false' }));
 
         const request = requests(app.start());
         request
@@ -225,7 +225,7 @@ describe('UIServer apis', () => {
             ? Promise.resolve({ ok: true, text: () => Promise.resolve('test-project') })
             : Promise.reject('Unexpected request'),
         );
-        app = new UIServer(loadConfigs(argv, {}));
+        app = new UIServer(loadConfigs(argv, { DISABLE_GKE_METADATA: 'false' }));
 
         const request = requests(app.start());
         request.get('/system/project-id').expect(200, 'test-project', done);

diff --git a/frontend/server/configs.ts b/frontend/server/configs.ts
@@ -108,7 +108,7 @@ export function loadConfigs(argv: string[], env: ProcessEnv): UIConfigs {
     /** The main container name of a pod where logs are retrieved */
     POD_LOG_CONTAINER_NAME = 'main',
     /** Disables GKE metadata endpoint. */
-    DISABLE_GKE_METADATA = 'false',
+    DISABLE_GKE_METADATA = 'true',
     /** Enable authorization checks for multi user mode. */
     ENABLE_AUTHZ = 'false',
     /** Deployment type. */

diff --git a/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml b/manifests/kustomize/env/gcp/gcp-configurations-patch.yaml
@@ -20,3 +20,17 @@ spec:
                 configMapKeyRef:
                   name: pipeline-install-config
                   key: gcsProjectId
+
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: ml-pipeline-ui
+spec:
+  template:
+    spec:
+      containers:
+        - name: ml-pipeline-ui
+          env:
+            - name: DISABLE_GKE_METADATA
+              value: 'false'