Fix crashing in FireFox #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
Fix security error for getAll On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
Fix security error for getAll On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
On big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on getAll because jss traverses all available CSS files. To bypass this error and make it work with FireFox, I have added a second argument to getAll function: sheet_name, where consumers can specify which CSS filename to take into account. This enables getAll to work on only one CSS file and thus to avoid security error.
FireFox adds properties that are undefined on read, which then crashes set function later on.
FireFox adds properties that are undefined on read, which then crashes set function later on.
FireFox adds properties that are undefined on read, which then crashes set function later on.
FireFox adds properties that are undefined on read, which then crashes set function later on.
FireFox adds properties that are undefined on read, which then crashes set function later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Fix security error for
getAllin FireFox when there are foreign domain CSS files includedOn big sites with dozens of CSS files included, where some of them are included from other domains, FireFox throws security error on
getAllbecause jss traverses all available CSS files. To bypass this error and make it work in FireFox, I have added a second argument togetAllfunction:sheet_name, where consumers can optionally specify which CSS filename to take into account. This enablesgetAllto work on only one CSS file and thus to avoid security error.FireFox adds properties that are undefined on read, which then crashes
setfunction later on.In a loop where one uses
getAllto get data and then latersetto create new data structures, in FireFox, jss was crashing because FireFox delivers a lot of properties with value 'undefined'.