feat: add get discord message logs api #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnhuyhoang
requested review from
huynguyenh,
namnhce and
lmquang
as code owners
namnhce
requested changes
Oct 8, 2024
pkg/model/discord_message.go
Outdated
Comment on lines
75
to
81
| ID string `json:"id"` | ||
| Content string `json:"content"` | ||
| AuthorName string `json:"author_name"` | ||
| AuthorID string `json:"author_id"` | ||
| ChannelID string `json:"channel_id"` | ||
| GuildID string `json:"guild_id"` | ||
| Timestamp time.Time `json:"timestamp"` |
pkg/handler/discord/discord.go
Outdated
| return | ||
| } | ||
| c.JSON(http.StatusOK, view.CreateResponse(messages, nil, nil, nil, "")) | ||
|
|
pkg/handler/discord/discord.go
Outdated
| c.JSON(http.StatusInternalServerError, view.CreateResponse[any](nil, nil, err, nil, "")) | ||
| return | ||
| } | ||
| c.JSON(http.StatusOK, view.CreateResponse(messages, nil, nil, nil, "")) |
namnhce
requested changes
Oct 8, 2024
pkg/handler/discord/discord.go
Outdated
Comment on lines
780
to
794
| // ListChannelMessageLogs godoc | ||
| // @Summary Get list of messages in channel and its thread | ||
| // @Description Get list of messages in channel and its thread | ||
| // @id ListChannelMessageLogs | ||
| // @Tags Discord | ||
| // @Accept json | ||
| // @Produce json | ||
| // @Param discord_channel_id path string true "Channel Discord ID" | ||
| // @Param startDate query string true "Start Date" | ||
| // @Param endDate query string true "End Date" | ||
| // @Success 200 {object} ListResearchTopicResponse | ||
| // @Failure 400 {object} ErrorResponse | ||
| // @Failure 404 {object} ErrorResponse | ||
| // @Failure 500 {object} ErrorResponse | ||
| // @Router /discords/{discord_channel_id}/message-logs [get] |
huynguyenh
reviewed
Oct 8, 2024
| } | ||
|
|
||
| for _, msg := range messages { | ||
| messageLogs = append(messageLogs, model.DiscordTextMessageLog{ |
There was a problem hiding this comment.
@namnhce @nnhuyhoang
this seems like a potential OOM, since on prod we only have 100MB-ish memory, make sure we dont OOM here
There was a problem hiding this comment.
will test on dev with the same amount of messages, if cannot handle them , find another way
huynguyenh
requested changes
Oct 8, 2024
| // @Router /discords/channels/{discord_channel_id}/message-logs [get] | ||
| func (h *handler) ListChannelMessageLogs(c *gin.Context) { | ||
| var input = request.GetChannelMessagesInput{ | ||
| DiscordChannelID: c.Param("discord_channel_id"), |
There was a problem hiding this comment.
@nnhuyhoang will this allow client call any discord_channel_id, if yes, gonna reject this for now
please follow up with me about this approach, need to validate/whitelist some channels only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?