-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy version #11
Conversation
Do you know why the error is occurring when
So it seems like something needs to be adjusted in the |
tests/test_integration.py
Outdated
@@ -111,7 +111,7 @@ def test_same_bqm(self): | |||
"""Run demo.py and demo_numpy.py with same inputs to check same BQM created.""" | |||
|
|||
w, h = (random.randint(10,20), random.randint(10,20)) | |||
num_poi, num_cs, num_new_cs = (random.randint(1,4), random.randint(1,4), random.randint(1,4)) | |||
num_poi, num_cs, num_new_cs = (random.randint(2,4), random.randint(2,4), random.randint(2,4)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do end up needing to enforce that num_new_cs>1
, it should be explained in the docstring why.
And then if that's the case, in this test, I think we'd only need to do:
num_poi, num_cs, num_new_cs = (random.randint(2,4), random.randint(2,4), random.randint(2,4)) | |
num_poi, num_cs, num_new_cs = (random.randint(1,4), random.randint(1,4), random.randint(2,4)) |
Also, I see that in |
The distance matrix getting written over is correct because it's a different distance matrix each time - I just reused the same object. |
@hhtong this should be resolved now. |
Update unittest for new test that is inconsistent.
Note: the unittest fails when num_new_cs = 1, so this has been updated to choose a number between 2 and 4 instead of 1 and 4.