Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibble-Zurek Mechanism with Noise Mitigation #31

Open
wants to merge 173 commits into
base: main
Choose a base branch
from

Conversation

k8culver
Copy link

@k8culver k8culver commented Jan 9, 2025

Thanks @AndyZzzZzzZzz for your work on this feature!

I can't remember if there were additional updates we wanted to add, all I've changed is cleaning up the code a bit and fixing the tests.

@jackraymond is going to help add tests for Andy's work.

I will follow this PR with a PR updating the code structure, adding more thorough doc strings, etc, for now this is mostly just Andy's updates.

JoelPasvolsky and others added 30 commits November 21, 2024 13:20
…d plot, and disable the function triger when changing inputs on couplings
… annealing_time parameter (bug in dwave-sampler?).
… calculation for kink_density plot (still need fixing)
mock_kz_sampler.py Outdated Show resolved Hide resolved
@k8culver k8culver marked this pull request as ready for review January 15, 2025 23:53
Copy link
Contributor

@thisac thisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some high-level comments (still have to review most of the code):

  • The logo and the tab-buttons aren't aligned with the edge and jump around quite a bit when resizing the window. It'd look better if they where at a constant distance from the edges, I think.
  • When running the ZNE simulation, curve fitting seems to happen after a couple of runs with different coupling strengths. This doesn't seem to work as it should. If the fit fails, there's a popup and everything is temporarily gone. If the fit finishes and a curve appears, the scaling seems to be off. It also disappears (being replaced with the sample data points) if switching view.
  • The original demo has no default value for QPU, causing an error (instead of a user-friendly warning) if a run is started without a chosen QPU.

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
demo_configs.py Outdated
Comment on lines 33 to 34
USE_CLASSICAL = True
J_BASELINE = -1.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on what these do?

helpers/tooltips.py Outdated Show resolved Hide resolved
@k8culver
Copy link
Author

  • The logo and the tab-buttons aren't aligned with the edge and jump around quite a bit when resizing the window. It'd look better if they where at a constant distance from the edges, I think.

The break point jumping behaviour is standard practice for web development that Dash has built in with their Container component. But I agree that the sides should be lined up so I'll remove the Container here.

@k8culver
Copy link
Author

  • The original demo has no default value for QPU, causing an error (instead of a user-friendly warning) if a run is started without a chosen QPU.

Yeah I agree, I wonder if @JoelPasvolsky has a suggestion on which would make a good default?

@JoelPasvolsky
Copy link
Collaborator

Yeah I agree, I wonder if @JoelPasvolsky has a suggestion on which would make a good default?

I'd suggest following Ocean, just using the default that would be selected by DWaveSampler() based o feature selection defaults

@k8culver
Copy link
Author

  • When running the ZNE simulation, curve fitting seems to happen after a couple of runs with different coupling strengths. This doesn't seem to work as it should. If the fit fails, there's a popup and everything is temporarily gone. If the fit finishes and a curve appears, the scaling seems to be off. It also disappears (being replaced with the sample data points) if switching view

@thisac I think I fixed this bug but let me know if you're still seeing it

@k8culver
Copy link
Author

@JoelPasvolsky @jackraymond @thisac I've made quite a few updates but I believe we're ready for another round of reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants