-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Di graph support #205
Di graph support #205
Conversation
Thanks for the PR! A few minor things but overall seems to be going in the right direction |
… be used correctly, minor test_tsp updates
…tworkx into DiGraph-Support Fix and merge branch stuff that I messed up.
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
==========================================
+ Coverage 71.15% 71.32% +0.16%
==========================================
Files 29 29
Lines 1751 1761 +10
==========================================
+ Hits 1246 1256 +10
Misses 505 505
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This is ready to merge?
Only thing left I guess is some test related stuff... I'm not sure how to test QUBO returned from |
This is ready to merge now imo :) |
Hello,
This is for #203.
It picks up where #200 left off.
I think I've made necessary changes except for some finishing the tests... but I could use a review and feedback :)