-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use alpine base #21
Use alpine base #21
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,12 @@ | ||
# Create the docker images locally. If a BUILD_NUM is provided, we will also | ||
# create an image with the tag BUILD_NUM. | ||
# Specify a specific dynamodb version by changing the DYNAMODB_VERSION=latest build flag as desired | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think a trick we can use here is this: DYNAMODB_VERSION ?= latest
build:
docker build -t dwmkerr/dynamodb:latest --build-arg DYNAMODB_VERSION=$(DYNAMODB_VERSION)
# etc... This way there's not even any need to change the makefile, the caller can just do: DYNAMODB_VERSION=1.2.3 make build Or even: make build DYNAMODB_VERSION=1.2.3 It's a really nice syntax - if the variable is not specified, the default (Nice reference here: https://adamcod.es/2016/11/15/makefile-variables.html) |
||
build: | ||
docker build -t dwmkerr/dynamodb:latest . | ||
docker build -t dwmkerr/dynamodb:latest --build-arg DYNAMODB_VERSION=latest . | ||
ifndef BUILD_NUM | ||
$(warning No build number is defined, skipping build number tag.) | ||
else | ||
docker build -t dwmkerr/dynamodb:$(BUILD_NUM) . | ||
docker build -t dwmkerr/dynamodb:$(BUILD_NUM) --build-arg DYNAMODB_VERSION=latest . | ||
endif | ||
|
||
# Run the tests. These do things like kill containers, so run with caution. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not make it work locally but it worked using
slim
tagsImage sizes:
Slim will not optimize the image size but it could be already considered an improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fell off my radar, I'll take a look now and try either getting it to work reliably or else use the slim tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give an example of what you ran to get the above error?
I also found this which may explain why: uber/h3-java#25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @jukie I was getting this kind of message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go for
slim
then, still an improvement and I love the build arg so want to get the changes in!