-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added methods and constants to SharpGL.Core to allow the use of VAO and PBO. #37
Open
jochemgeussens
wants to merge
8
commits into
dwmkerr:main
Choose a base branch
from
jochemgeussens:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Objects (VAO) and Pixel Buffer Objects (PBO). Note that this is the first methods that I've added, so it might not work (even though no errors were found during the test). Confirmation required!
…lBufferData overloads with uint and byte.
Thanks @jochemgeussens I'll look into merging this for the forthcoming release :) |
…Pixel Buffer Objects (Still some issues with it). Removed some GL calls from OpenGLControl and SceneView, that in my opinion should be left by the user, because it might cause confusion (Like OpenGL.GL_DEPTH_TEST). Note that this might require for the samples to be double checked! Added missing constants and function calls to OpenGLExtensionsJOG.cs for review. If approved then they can be added to OpenGL.cs or OpenGLExtensions.cs. Upgraded and added classes to SceneGraph.JOG. This includes a less restrictive and - in my opinion - more OGL natural ShaderProgram.cs, Color.cs,... Added samples to share my experience with OpenGL for the last 2 months. It should mostly follow the OGL 3.3+ conventions, except for the Gradient Backgrounds, who still use deprecated functionalities. The samples which are currently working include "Translucency", "Particle Systems", "Use of materials", "Lines". Note that for the examples, it is required to install GlmNET, which can be easely retrieved from Nuget in Visual Studio.
NOTE: triangulation only works for quads and the reading algorithm has only been tested for vertex positions(v), normals (vn) and faces (f). And will probably give issues if the faces include more than just vertex positions and normal positions. OpenFileDialog results into not displaying any buffer data anymore for some yet unknown reason. Just entering the URL and press "Open from URL" works without a problem.
I'd love to be able to bring this in, but it's just absolutely huge - if the PR can be split up into smaller chunks that'd make it easier, much of this functionality is available now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.