Toon shader sample #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Robin, I'd like to get 2.4 out ASAP so I'm going to take this issue off the 2.4 milestone and we'll re-assign it to a later one |
|
That's fine! Was something I did while writing the article. Date: Sat, 24 Jan 2015 09:57:22 -0800 Hi Robin, I'd like to get 2.4 out ASAP so I'm going to take this issue off the 2.4 milestone and we'll re-assign it to a later one — |
|
Looks great, again can we get a version of the PR which only has the required changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dave!
While writing the article, I added a toon vertex and fragment shader to the SimpleShaderSample. Maybe you like to merge it into the master branch!? Just a suggestion. ;)
Best regards!
Robin