This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
fix(metadataRetriever): get tabs with tooling api #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #737 and #738
Summary of changes
It looks like the Tooling API returns more
TabDefinition
s records (and therefore more accurate) than the SOAP API.These are the ones which are mentioned to be missing in #737.
They are now included in the
sfpowerkit:source:profile:retrieval
and retained in thesfpowerkit:source:profile:reconcile
command.Here is the diff from the output of running
sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition"
vs.
sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition" --usetoolingapi
Checklist
sfpowerkit:source:profile:retrieval
andsfpowerkit:source:profile:reconcile
commands