Add longer wait/backoff if blinds position doesn't change #31

dxdc · Apr 15, 2020 · 9b1ff37 · 9b1ff37
1 parent 26d8d09
commit 9b1ff37
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -436,8 +436,18 @@ BlindsHTTPAccessory.prototype.setTargetPosition = function(pos, callback) {
             let targetReached = false;
             let positionRetries = 0;
 
+            let intervalsToSkip = 0;
+            let lastIntervalPosition = -1;
+
             self.stepInterval = setInterval(function() {
                 if (targetReached) {
+                    if (intervalsToSkip > 1) {
+                        --intervalsToSkip;
+                    } else if (intervalsToSkip === 1) {
+                        intervalsToSkip = 0;
+                        targetReached = false;
+                    }
+
                     return; // avoid duplicate calls
                 }
 
@@ -466,8 +476,15 @@ BlindsHTTPAccessory.prototype.setTargetPosition = function(pos, callback) {
                             if (positionRetries > 10) {
                                 self.log.error(`Didn't reach target after ${positionRetries} tries`);
                                 self.manualStop = true;
+                            } else if (self.lastPosition === lastIntervalPosition) {
+                                if (self.verbose) {
+                                    self.log.info(`Blinds position didn't change: skipping ${positionRetries} cycle${positionRetries > 1 ? 's' : ''}`);
+                                }
+                                intervalsToSkip = positionRetries;
+                                return;
                             }
 
+                            lastIntervalPosition = self.lastPosition;
                             targetReached = false;
                         }
                     }.bind(self));