Skip to content

Commit

Permalink
Keep Dockerfile Node version up to date
Browse files Browse the repository at this point in the history
This will ensure that the major version of Node used for setup by Docker
will match the version in the .node-version file. We did this in Apply
for Landing after encountering an engine mismatch error on a Renovate PR
bumping the major version

dxw/dfsseta-apply-for-landing-ruby@acc2319
  • Loading branch information
yndajas committed Oct 31, 2024
1 parent 071fd4c commit 084587c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
FROM ruby:3.3.5 as base
LABEL org.opencontainers.image.authors="[email protected]"

RUN curl -L https://deb.nodesource.com/setup_20.x | bash -
COPY .node-version .node-version
RUN curl -L "https://deb.nodesource.com/setup_$(cat .node-version | cut -c1-2).x" | bash -
RUN curl https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
RUN \
echo "deb https://dl.yarnpkg.com/debian/ stable main" | \
Expand Down

0 comments on commit 084587c

Please sign in to comment.