Fix: Production docker image built without test gems

Dockerfile

@@ -19,9 +19,8 @@ RUN \
 ENV APP_HOME /srv/app
 ENV DEPS_HOME /deps
 
-ARG RAILS_ENV
-ENV RAILS_ENV ${RAILS_ENV:-production}
-ENV NODE_ENV ${RAILS_ENV:-production}
+ENV RAILS_ENV=production
+ENV NODE_ENV=production
 
 # ------------------------------------------------------------------------------
 # Dependencies
@@ -42,26 +41,20 @@ RUN gem update --system 3.3.5
 RUN gem install bundler -v 2.3.5
 RUN bundle config set frozen "true"
 RUN bundle config set no-cache "true"
-RUN bundle config set with "${BUNDLE_GEM_GROUPS}"
+RUN bundle config set without development test
 RUN bundle install --retry=10 --jobs=4
 # End
 
 # Install Javascript dependencies
 COPY yarn.lock ${DEPS_HOME}/yarn.lock
 COPY package.json ${DEPS_HOME}/package.json
 
-RUN \
-  if [ ${RAILS_ENV} = "production" ]; then \
-  yarn install --frozen-lockfile --production; \
-  else \
-  yarn install --frozen-lockfile; \
-  fi
-# End
+RUN yarn install --frozen-lockfile --production
 
 # ------------------------------------------------------------------------------
-# Web
+# Production
 # ------------------------------------------------------------------------------
-FROM base AS web
+FROM base AS production
 
 WORKDIR ${APP_HOME}
 
@@ -119,10 +112,32 @@ EXPOSE 3000
 
 CMD ["bundle", "exec", "rails", "server"]
 
+# ------------------------------------------------------------------------------
+# Development
+# ------------------------------------------------------------------------------
+FROM production as development
+
+ENV RAILS_ENV=development
+ENV NODE_ENV=development
+
+RUN bundle config unset without
+RUN bundle config set with development
+RUN bundle install --retry=10 --jobs=4
+
+# Define the runtime command in docker-compose.yml
+CMD ["bundle", "exec", "rails", "console"]
+
 # ------------------------------------------------------------------------------
 # Test
 # ------------------------------------------------------------------------------
-FROM web as test
+FROM production as test
+
+ENV RAILS_ENV=test
+ENV NODE_ENV=test
+
+RUN bundle config unset without
+RUN bundle config set with test
+RUN bundle install --retry=10 --jobs=4
 
 RUN \
   apt-get update && \
@@ -139,3 +154,8 @@ COPY .stylelintignore ${APP_HOME}/.stylelintignore
 
 COPY .rspec ${APP_HOME}/.rspec
 COPY spec ${APP_HOME}/spec
+
+RUN yarn install --frozen-lockfile
+
+# Define the runtime command in docker-compose.test.yml
+CMD ["bundle", "exec", "rake"]

Rakefile

@@ -7,5 +7,7 @@ require_relative "config/application"
 
 Rails.application.load_tasks
 
-desc "Run all the tests"
-task default: %i[spec standard]
+if Rails.env.development? || Rails.env.test?
+  desc "Run all the tests"
+  task default: %i[spec standard]
+end

config/environments/production.rb

@@ -27,7 +27,7 @@
   config.public_file_server.enabled = ENV["RAILS_SERVE_STATIC_FILES"].present?
 
   # Compress JavaScripts and CSS.
-  config.assets.js_compressor = :uglifier
+  config.assets.js_compressor = Uglifier.new(harmony: true)
   # Set a css_compressor so sassc-rails does not overwrite the compressor when running the tests
   config.assets.css_compressor = nil
 

docker-compose.ci.yml

@@ -4,8 +4,6 @@ services:
     build:
       context: .
       target: test
-      args:
-        RAILS_ENV: "test"
       cache_from:
         - app_test:latest
     image: app_test

docker-compose.test.yml

@@ -4,8 +4,6 @@ services:
     build:
       context: .
       target: test
-      args:
-        RAILS_ENV: "test"
     command: bundle exec rake
     ports:
       - "3000:3000"

docker-compose.yml

@@ -3,9 +3,7 @@ services:
   web:
     build:
       context: .
-      target: web
-      args:
-        RAILS_ENV: "development"
+      target: development
     command: bash -c "rm -f tmp/pids/server.pid && bundle exec rails s -p 3000 -b '0.0.0.0'"
     ports:
       - "3000:3000"