Maintenance #726
Merged
Maintenance #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a runtime error. We've had to do similar in the DfSSETA example app and RODA after various upgrades: - UKGovernmentBEIS/beis-report-official-development-assistance@e11a6fb - dxw/dfsseta-apply-for-landing-ruby@dbe1ffb The following is printed in the console before the error and backtrace: ``` Please, set config.cache_classes to false in config/environments/test.rb. ```
This fixes a deprecation warning and follows the linked guidance: ``` DEPRECATION WARNING: Support for `config.active_support.cache_format_version = 6.1` has been deprecated and will be removed in Rails 7.2. Check the Rails upgrade guide at https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format for more information on how to upgrade. ```
This fixes an error when trying to drop the database locally: ``` /Users/ynda/code/github.com/dxw/rails-template/vendor/bundle/ruby/3.3.0/gems/puma-5.6.8/lib/rack/version_restriction.rb:12:in `<main>': Puma 5 is not compatible with Rack 3, please upgrade to Puma 6 or higher. (StandardError) ``` We're already on 6.4 in the DfSSETA example app and RODA
I think this folder is generated and used by a VS Code extension (it's not visible in the VS Code file explorer) and doesn't show up in git (without being mentioned in `.gitignore`)
The shellcheck exits with the following message without this: ``` In script/no-docker/setup line 27: read -r ^--^ SC3061 (warning): In POSIX sh, read without a variable is undefined. In script/no-docker/setup line 49: read -r ^--^ SC3061 (warning): In POSIX sh, read without a variable is undefined. ``` Typically `read` without a variable implicitly assigns the user input to `$REPLY`, but because we're using `#!/bin/sh` (not Bash) we need to provide a variable name explicitly
This is now plural ``` Rails 7.1 has deprecated the singular fixture_path in favour of an array.You should migrate to plural: ```
jdudley1123
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
#712 was failing to rebase automatically, and didn't seem to be updating to the version as described. I had a look at the branch locally and encountered a few issues. This is a collection of updates to bring things a little more up to date (and less broken)
Closes #712
Next steps
accessibility testing
on this feature.