Compile assets in Docker-less setup and update scripts #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickjfl
approved these changes
Nov 1, 2024
This was added in Apply for Landing last year and seems like a useful default for smoother onboarding "If you don't already have the compiled assets in `app/assets/builds`, `script/test` will fail and pages will fail to load using `script/server`. This adds the build step to the Docker-less `setup` and `update` scripts, the latter of which is used in the `test` and `server` scripts, to ensure the assets are compiled before they're needed" dxw/dfsseta-apply-for-landing-ruby@f56c707#diff-803dcb1d5b5cec24bdc12fdfd664507c8ef37a24deab57275c915b0a7af48a67R19
yndajas
force-pushed
the
compile-assets-in-scripts
branch
from
c329e36 to
b33baf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in Apply for Landing last year and seems like a useful default for smoother onboarding
"If you don't already have the compiled assets in
app/assets/builds,script/testwill fail and pages will fail to load usingscript/server. This adds the build step to the Docker-lesssetupandupdatescripts, the latter of which is used in thetestandserverscripts, to ensure the assets are compiled before they're needed"dxw/dfsseta-apply-for-landing-ruby@f56c707#diff-803dcb1d5b5cec24bdc12fdfd664507c8ef37a24deab57275c915b0a7af48a67R19