Replace Slack with Rollbar #107
Merged
+12
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
reviewed
Nov 2, 2023
dragon-dxw
approved these changes
Nov 2, 2023
|
Given that many of the errors will lead to (minor) data loss in Productive, it's probably worth configuring Rollbar to alert on every error, rather than just 1st, 10th, 100th etc. |
CristinaRO
reviewed
Nov 2, 2023
There was a problem hiding this comment.
Good find! I think we had considered Rollbar, but there were too many unknowns, especially with us not being able to access the app on Heroku and configure anything independently, which is the only reason we went with a Slack integration.
I have a question about the raising or not of the error.
jdudley1123
force-pushed
the
replace-slack-with-rollbar
branch
from
f812079 to
68b93f0
Compare
jdudley1123
force-pushed
the
replace-slack-with-rollbar
branch
from
68b93f0 to
039748c
Compare
CristinaRO
approved these changes
Nov 7, 2023
Currently we use a Slack integration to post error messages to Slack. This change replaces that integration with Rollbar. This change brings this project in line with our standard approach of using Rollbar, and also simplifies the code.
jdudley1123
force-pushed
the
replace-slack-with-rollbar
branch
from
039748c to
705715d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently we use a Slack integration to post error messages to Slack. This is unusual for our projects, as we normally use Rollbar which requires less configuration.
This PR
This PR replaces the Slack integration with Rollbar, bringing this project in line with our standard approach.
Note
If we merge this PR we will also need to delete the Slack app: https://api.slack.com/apps/A04U1KEJFKR/general