Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix a flaky test
com.didispace.chapter21.Chapter21ApplicationTests#testUserController
in module2.x/chapter2-1
, we found it when using the latest version of SpringBoot-Learning:Why it fails:
Line 52 of
2.x/chapter2-1/src/test/java/com/didispace/chapter21/Chapter21ApplicationTests.java
converts a JSON object to a string. Note that this conversion does not guarantee the order of the elements.Fix:
Use
json()
to compare Json objects instead of converting them to string.