-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FNS with book building algorithm overview + fill amounts clarification #245
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2. Discard messages until you receive a `StreamOrderbookUpdate` with `snapshot` set to `true`. This message contains the full orderbook state for each clob pair. | ||
3. When you see an `OrderPlaceV1` message, insert the order into the book at the end of the queue on its price level. Track the order's initial quantums (quantity) and total filled quantums. | ||
4. When you see an `OrderUpdateV1` message, update the order's total filled quantums. | ||
5. When you see a `ClobMatch` (trade) message, update the total filled quantums for each maker order filled using the `fill_amounts` field. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like adding some note as to why there's both OrderUpdateV1
and ClobMatch
would be helpful. I could imagine this be really confusing why there are two different messages that feel like they are keeping tracking of the exact same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All suggestions, no must fix problems I see. Biggest thing is that the titles get less consistent towards the bottom of the page, everything else market as a nit
2. Generate the protos: `make proto-gen && make proto-export-deps`. | ||
3. The generated protos are now in the `.proto-export-deps` directory. | ||
4. Use the protobuf compiler (protoc) to [generate stubs](https://protobuf.dev/getting-started/) in any supported language. | ||
5. Follow the documentation to write a streaming client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5. Follow the documentation to write a streaming client. | |
5. Follow the [composite client documentation](api_integration-clients/composite_client) to write a streaming client. |
nit: is there a page we can link to? Above for example, I'm not sure that's the right page
|
||
</details> | ||
|
||
## FAQs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's another FAQ section within this one with questions and answers, I think this should either be:
- renamed something more general like "Reference Material," or
- deleted and the subsections elevated
|
||
Note that DeliverTx maps to exec mode `execModeFinalize`. | ||
|
||
### What Are the Exec Modes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this fit a little better on this page, I suggest either:
- renaming this to not be a question, e.g. "Exec Mode Reference", or
- moving it to the FAQ section and reformatting it there (Q: what are... )
I also think the code snippet could stay expanded because it helps break up the page at a glace
Co-authored-by: zach <[email protected]>
Co-authored-by: zach <[email protected]>
This PR:
ClobMatch
andOrderUpdateV1
to know the book state)