Merge pull request #162 from muskie9/refactor/onBeforeUpdateCMSFields

REFACTOR header image getCMSFields
dynamic · Nov 14, 2018 · 71edfdf · 71edfdf
2 parents 80746ab + 432eacd
commit 71edfdf
Showing 1 changed file with 30 additions and 29 deletions.
diff --git a/src/Model/HeaderImage.php b/src/Model/HeaderImage.php
@@ -7,6 +7,7 @@
 use SilverStripe\AssetAdmin\Forms\UploadField;
 use SilverStripe\Assets\Image;
 use SilverStripe\CMS\Model\SiteTree;
+use SilverStripe\Forms\FieldList;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\Security;
 
@@ -46,35 +47,35 @@ class HeaderImage extends DataObject
      */
     public function getCMSFields()
     {
-        $fields = parent::getCMSFields();
-
-        $fields->removeByName([
-            'HeaderLinkID',
-            'Image',
-            'PageID',
-        ]);
-
-        $fields->insertAfter(
-            'Content',
-            LinkField::create('HeaderLinkID', 'Link')
-        );
-
-        $image_field = UploadField::create('Image', 'Header Image')
-            ->setFolderName('Uploads/HeaderImages')
-            ->setIsMultiUpload(false);
-        $image_field->getValidator()->allowedExtensions = array(
-            'jpg',
-            'jpeg',
-            'gif',
-            'png',
-        );
-
-        $fields->insertBefore(
-            'Title',
-            $image_field
-        );
-
-        return $fields;
+        $this->beforeUpdateCMSFields(function (FieldList $fields) {
+            $fields->removeByName([
+                'HeaderLinkID',
+                'Image',
+                'PageID',
+            ]);
+
+            $fields->insertAfter(
+                'Content',
+                LinkField::create('HeaderLinkID', 'Link')
+            );
+
+            $image_field = UploadField::create('Image', 'Header Image')
+                ->setFolderName('Uploads/HeaderImages')
+                ->setIsMultiUpload(false);
+            $image_field->getValidator()->allowedExtensions = [
+                'jpg',
+                'jpeg',
+                'gif',
+                'png',
+            ];
+
+            $fields->insertBefore(
+                'Title',
+                $image_field
+            );
+        });
+
+        return parent::getCMSFields();
     }
 
     /**