Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product CMS Field design #374

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Dec 5, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #374 into master will increase coverage by 0.11%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #374      +/-   ##
============================================
+ Coverage     28.97%   29.09%   +0.11%     
- Complexity      441      444       +3     
============================================
  Files            28       28              
  Lines          1829     1832       +3     
============================================
+ Hits            530      533       +3     
  Misses         1299     1299
Impacted Files Coverage Δ Complexity Δ
src/Model/OptionItem.php 5.19% <0%> (ø) 28 <0> (ø) ⬇️
src/Page/ProductPage.php 17.12% <18.75%> (+1.73%) 34 <2> (+3) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7e1c7...15a0345. Read the comment docs.

@muskie9
Copy link
Member

muskie9 commented Mar 26, 2019

@jsirish can you confirm this all still looks as expected in the CMS. If so I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants