FEATURE initial modeling #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muskie9
reviewed
Sep 4, 2024
composer.json
Outdated
| "autoload": { | ||
| "psr-4": { | ||
| "Dynamic\\Elements\\Locations\\": "src/", | ||
| "Dynamic\\Elements\\Blog\\Locations\\": "tests/" | ||
| "Dynamic\\Elements\\\\Locations\\Test\\": "tests/" |
There was a problem hiding this comment.
Two too many \\ between Elements and Locations?
muskie9
reviewed
Sep 4, 2024
src/Model/Location.php
Outdated
| * @var array | ||
| */ | ||
| private static $has_many = [ | ||
| 'Links' => Link::class, |
There was a problem hiding this comment.
I think for a has many it needs to be Link::class . '.Owner' just in case extensions apply additional link relations.
jsirish
force-pushed
the
feature/initialModeling
branch
from
14aeba8 to
4ae7e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.