refactor - tweak default values for Slider settings (#146)

Use DirectionNav vs. ControlNav in carousel and thumbnail carousel
dynamic · Sep 24, 2018 · 9cc9049 · 9cc9049
1 parent 7491577
commit 9cc9049
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/src/FlexSlider.php b/src/FlexSlider.php
@@ -62,7 +62,7 @@ public function populateDefaults()
         parent::populateDefaults();
         $this->owner->Loop = 1;
         $this->owner->Animate = 1;
-        $this->owner->SliderControlNav = 1;
+        $this->owner->SliderControlNav = 0;
         $this->owner->SliderDirectionNav = 1;
         $this->owner->CarouselControlNav = 0;
         $this->owner->CarouselDirectionNav = 1;

diff --git a/tasks/SlidePublishTask.php b/tasks/SlidePublishTask.php
@@ -57,10 +57,8 @@ public function publishSlides()
                 if (!$slide->Name) {
                     $slide->Name = "No Name";
                 }
-                $title = $slide->Name;
                 $slide->writeToStage('Stage');
                 $slide->publishRecursive();
-                static::write_message($slide->Name . " updated");
                 ++$ct;
             }
         }

diff --git a/tasks/SlideThumbnailNavMigrationTask.php b/tasks/SlideThumbnailNavMigrationTask.php
@@ -4,6 +4,7 @@
 
 use Dynamic\FlexSlider\ORM\FlexSlider;
 use SilverStripe\CMS\Model\SiteTree;
+use SilverStripe\Control\Director;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Dev\BuildTask;
 use SilverStripe\ORM\DataObject;
@@ -65,7 +66,7 @@ public function defaultSliderSettings()
                     foreach ($this->getObjectSet($object) as $result) {
                         $result->Loop = 1;
                         $result->Animate = 1;
-                        $result->SliderControlNav = 1;
+                        $result->SliderControlNav = 0;
                         $result->SliderDirectionNav = 1;
                         $result->CarouselControlNav = 0;
                         $result->CarouselDirectionNav = 1;
@@ -83,6 +84,18 @@ public function defaultSliderSettings()
                 }
             }
         }
-        echo '<p>'.$ct.' Sliders updated.</p>';
+        static::write_message($ct . " Sliders updated");
+    }
+
+    /**
+     * @param $message
+     */
+    protected static function write_message($message)
+    {
+        if (Director::is_cli()) {
+            echo "{$message}\n";
+        } else {
+            echo "{$message}<br><br>";
+        }
     }
 }