Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fixed mistaken namespace #242

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Bugfix: Fixed mistaken namespace #242

merged 2 commits into from
Mar 24, 2024

Conversation

nathanbrauer
Copy link
Contributor

@nathanbrauer nathanbrauer commented Mar 8, 2024

Originally, Location and LocationCategory were located under Dynamic\Locator\

At 4.0.0 they were moved to Dynamic\Locator\Model\; however Location didn't get completely migrated over, causing fatal errors when running related /dev/tasks.

This pull request completes the migration.

PS: ...and also updates some inconsequential http links to https

@nathanbrauer nathanbrauer requested a review from muskie9 March 8, 2024 20:40
@nathanbrauer nathanbrauer marked this pull request as draft March 8, 2024 20:45
@nathanbrauer nathanbrauer force-pushed the bugfix/namespace-mixup branch from 8dd7537 to 00f1523 Compare March 8, 2024 21:03
@nathanbrauer nathanbrauer marked this pull request as ready for review March 8, 2024 21:03
Fixes fatal failure in Tasks
Fixes fatal failure in Tasks
@nathanbrauer nathanbrauer force-pushed the bugfix/namespace-mixup branch from 00f1523 to c328132 Compare March 8, 2024 21:31
@nathanbrauer
Copy link
Contributor Author

(Separated into two commits so I could create a patch without the tests dir.)

@nathanbrauer
Copy link
Contributor Author

@muskie9 - bringing your attention do this :)

@muskie9
Copy link
Member

muskie9 commented Mar 24, 2024

Sorry @nathanbrauer, I saw the initial notification and it then got buried. I'm reviewing.

@muskie9 muskie9 merged commit 59311ec into 4 Mar 24, 2024
12 of 18 checks passed
@muskie9
Copy link
Member

muskie9 commented Mar 24, 2024

@nathanbrauer all set. I'll look at getting a new release unless there are further updates you've seen as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants