Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR invitation from email #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Oct 10, 2023

Send from current user vs. admin_email.

If admin_email is not set in config it throws an error.

Send from current user vs. admin_email.

If `admin_email` is not set in config it throws an error.
@jsirish jsirish requested a review from muskie9 October 10, 2023 21:04
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/Model/UserInvitation.php 96.22% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@thomasbnielsen
Copy link
Contributor

I have just made an update that i would like merged in, i have updated the readme with info about needing to set admin_email. I do not think it is a good idea to use users email, as that can be from another domain / service thus it will end up in spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants