Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[geth] remove --metrics.expensive flag #317

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[geth] remove --metrics.expensive flag #317

merged 2 commits into from
Sep 3, 2024

Conversation

VladStarr
Copy link
Contributor

@VladStarr VladStarr commented Aug 27, 2024 •
edited
Loading

  1. Collection of expensive metrics is enabled by default now
WARN [08-27|08:26:31.512] Expensive metrics are collected by default, please remove this flag flag=metrics.expensive

If there is need to disable expensive metrics, extraArgs can be used.

  1. Bumped initial PVC size as of 09/2024

voron
voron approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@voron voron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladStarr VladStarr force-pushed the geth-remove-expensive-metrics branch from 41d8e81 to ac3f285 Compare September 3, 2024 14:32
@VladStarr VladStarr merged commit 24f4f74 into main Sep 3, 2024
2 checks passed
@VladStarr VladStarr deleted the geth-remove-expensive-metrics branch September 3, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voron voron voron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladStarr @voron