Skip to content

Commit

Permalink
🚨 Linting
Browse files Browse the repository at this point in the history
  • Loading branch information
trymzet committed Aug 19, 2024
1 parent 91d185d commit 04912f4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,4 @@ profiles.yaml
*.secret

# AWS
.aws
.aws
3 changes: 1 addition & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]


- Added new version of `Genesys` connector and test files.
- Added new version of `Outlook` connector and test files.
- Added new version of `Hubspot` connector and test files.
- Added `Mindful` connector and test file.


### Added

- Added `sap_to_parquet` Prefect flow.
Expand Down Expand Up @@ -71,6 +69,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed `catch_extra_separators()` from `SAPRFCV2` class

### Fixed

- Fixed the typo in credentials in `SQLServer` source

## [0.4.3] - 2022-04-28
Expand Down
7 changes: 5 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,19 +76,20 @@ Commit messages should:
- start with one of the following verbs, capitalized, immediately after the summary emoji: "Add", "Update", "Remove", "Fix", "Rename", and, sporadically, other ones, such as "Upgrade", "Downgrade", or whatever you find relevant for your particular situation
- contain a useful summary of what the commit is doing

See [this article](https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/) to understand the basics of commit naming.
See [this article](https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/) to understand the basics of commit naming.

## Submitting a PR

1. [Fork the repo](https://github.com/dyvenia/viadot/fork)
2. Uncheck the "Copy the `main` branch only" box
3 Follow the setup outlined above
3. Follow the setup outlined above
4. Checkout a new branch

```console
# Make sure that your base branch is `2.0`.
git switch 2.0 && git checkout -b <name>
```

5. Add your changes
6. Sync your fork with the `dyvenia` repo

Expand All @@ -98,11 +99,13 @@ Commit messages should:
git switch 2.0
git rebase upstream/2.0
```

7. Push the changes to your fork

```console
git push --force
```

8. [Submit a PR](https://github.com/dyvenia/viadot/compare/2.0...main) into the `2.0` branch.

Make sure to read & check all relevant checkboxes in the PR description!
Expand Down
2 changes: 1 addition & 1 deletion config.yaml.example
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ sources:
client_id: your_client_id
client_secret: your_client_secret
tenant_id: your_tenant_id

- hubspot_dev:
class: Hubspot
credentials:
Expand Down

0 comments on commit 04912f4

Please sign in to comment.