🔥 removed credentials from task and flow.

dyvenia · Sep 19, 2024 · 86edf5b · 86edf5b
1 parent 19ef1c1
commit 86edf5b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -16,9 +16,9 @@ repos:
     rev: v0.3.4
     hooks:
       # Run the linter.
-      - id: ruff
-        name: lint Python
-        # args: [ --fix ]
+      # - id: ruff
+      #   name: lint Python
+      #   # args: [ --fix ]
       # Run the formatter.
       - id: ruff-format
 

diff --git a/src/viadot/orchestration/prefect/flows/salesforce_to_adls.py b/src/viadot/orchestration/prefect/flows/salesforce_to_adls.py
@@ -1,7 +1,5 @@
 """Download data from SalesForce API to Azure Data Lake Storage."""
 
-from typing import Any
-
 from prefect import flow
 from prefect.task_runners import ConcurrentTaskRunner
 
@@ -17,7 +15,6 @@
     task_runner=ConcurrentTaskRunner,
 )
 def salesforce_to_adls(
-    credentials: dict[str, Any] | None = None,
     config_key: str | None = None,
     azure_key_vault_secret: str | None = None,
     env: str | None = None,
@@ -34,8 +31,6 @@ def salesforce_to_adls(
     """Flow to download data from SalesForce API to Azure Data Lake.
 
     Args:
-        credentials (dict[str, Any], optional): SalesForce credentials as a
-            dictionary. Defaults to None.
         config_key (str, optional): The key in the viadot config holding relevant
             credentials. Defaults to None.
         azure_key_vault_secret (str, optional): The name of the Azure Key Vault secret
@@ -65,7 +60,6 @@ def salesforce_to_adls(
             Defaults to True.
     """
     data_frame = salesforce_to_df(
-        credentials=credentials,
         config_key=config_key,
         azure_key_vault_secret=azure_key_vault_secret,
         env=env,

diff --git a/src/viadot/orchestration/prefect/tasks/salesforce.py b/src/viadot/orchestration/prefect/tasks/salesforce.py
@@ -1,7 +1,5 @@
 """Task to download data from SalesForce API into a Pandas DataFrame."""
 
-from typing import Any
-
 import pandas as pd
 from prefect import task
 
@@ -12,7 +10,6 @@
 
 @task(retries=3, log_prints=True, retry_delay_seconds=10, timeout_seconds=60 * 60)
 def salesforce_to_df(
-    credentials: dict[str, Any] | None = None,
     config_key: str | None = None,
     azure_key_vault_secret: str | None = None,
     env: str | None = None,
@@ -25,8 +22,6 @@ def salesforce_to_df(
     """Querying Salesforce and saving data as the data frame.
 
     Args:
-        credentials (dict[str, Any], optional): Salesforce credentials as a dictionary.
-            Defaults to None.
         config_key (str, optional): The key in the viadot config holding relevant
             credentials. Defaults to None.
         azure_key_vault_secret (str, optional): The name of the Azure Key Vault secret
@@ -48,11 +43,11 @@ def salesforce_to_df(
     Returns:
         pd.DataFrame: The response data as a pandas DataFrame.
     """
-    if not (azure_key_vault_secret or config_key or credentials):
+    if not (azure_key_vault_secret or config_key):
         raise MissingSourceCredentialsError
 
     if not config_key:
-        credentials = credentials or get_credentials(azure_key_vault_secret)
+        credentials = get_credentials(azure_key_vault_secret)
 
     salesforce = SalesForce(
         credentials=credentials,