Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Supermetrics source and Prefect tasks #1054

Merged
merged 11 commits into from
Sep 26, 2024
Merged

✨ Add Supermetrics source and Prefect tasks #1054

merged 11 commits into from
Sep 26, 2024

Conversation

angelika233
Copy link
Contributor

Summary

Supermetrics migration

Importance

migration

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@angelika233 angelika233 requested a review from trymzet September 25, 2024 10:09
trymzet
trymzet requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments. Also, pls make sure linting check passes.

tests/integration/orchestration/prefect/flows/test_supermetrics.py Outdated Show resolved Hide resolved
tests/unit/test_supermetrics.py Show resolved Hide resolved
tests/unit/test_supermetrics.py Outdated Show resolved Hide resolved
This was referenced Sep 26, 2024
Closed
Closed
@angelika233
Copy link
Contributor Author

angelika233 commented Sep 26, 2024 •
edited
Loading

I added issue for improving the tests #1059

@angelika233 angelika233 requested a review from trymzet September 26, 2024 09:32
@trymzet trymzet mentioned this pull request Sep 26, 2024
Open
@trymzet trymzet merged commit f316721 into 2.0 Sep 26, 2024
3 checks passed
@trymzet trymzet deleted the supermetrics_2.0.1 branch September 26, 2024 09:58
@trymzet trymzet changed the title Migrate supermetrics ✨ Add Supermetrics source and Prefect tasks Sep 27, 2024
@trymzet trymzet added the 2.0 viadot 2.0 label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
2.0 viadot 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelika233 @trymzet @fdelgadodyvenia