✨ Add TM1 source and Prefect tasks
#1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trymzet
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Added my feedback, overall looks pretty good. I recommend getting familiarized with the concept of pure functions - it would make some of the code cleaner (some of the feedback below is essentially to make the functions pure). Eg. Arjan has a good video on it https://www.youtube.com/watch?v=4B24vYj_vaI
trymzet
requested changes
Dec 4, 2024
judynah
force-pushed
the
tm1
branch
3 times, most recently
from
7ed5371 to
d19e53f
Compare
trymzet
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TM1 connector migration from viadot 1 to viadot 2.
Update docs in Business Core Prefect task.
Importance
Required by the migration project.
Checklist
This PR:
CONTRIBUTING.mdCHANGELOG.md