Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 updated documentation #754

Merged
merged 2 commits into from
Oct 11, 2023
Merged

📝 updated documentation #754

merged 2 commits into from
Oct 11, 2023

Conversation

angelika233
Copy link
Contributor

Summary

fixed doctring

Importance

fix

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Rafalz13
Rafalz13 reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add also docstring to the Class C4CToDF and init method? For now the docstring is only for run and _generate_chunks.

viadot/tasks/cloud_for_customers.py Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 merged commit c7d917d into dyvenia:dev Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelika233 @Rafalz13