Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate_df task to BigQueryToADLS flow #779

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Add validate_df task to BigQueryToADLS flow #779

merged 4 commits into from
Oct 26, 2023

Conversation

jkrobicki
Copy link
Contributor

Summary

  • Added validate_df_dict parameter to BigQueryToADLS flow
  • Added tests for the new parameter in the BigQueryToADLS flow

Importance

New functionality to check the data

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@jkrobicki jkrobicki requested review from m-paz and gwieloch October 25, 2023 12:50
@jkrobicki jkrobicki changed the title Add validate_df task to BigQueryToADLS flow Add validate_df task to BigQueryToADLS flow Oct 25, 2023
gwieloch
gwieloch requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@gwieloch gwieloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls change new parameter to validate_df_dict

viadot/flows/bigquery_to_adls.py Outdated
@@ -40,6 +41,7 @@ def __init__(
adls_sp_credentials_secret: str = None,
overwrite_adls: bool = False,
if_exists: str = "replace",
validation_df_dict: dict = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate_df_dict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@m-paz m-paz merged commit 15fabd7 into dyvenia:dev Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwieloch gwieloch gwieloch approved these changes

@m-paz m-paz m-paz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkrobicki @m-paz @gwieloch