Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TM1 connector #801

Merged
merged 13 commits into from
Nov 13, 2023
Merged

Added TM1 connector #801

merged 13 commits into from
Nov 13, 2023

Conversation

angelika233
Copy link
Contributor

Summary

Source and task class for TM1. Download is based on cube and view name

Importance

Added new data source

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@angelika233 angelika233 requested a review from Rafalz13 November 2, 2023 13:39
marcinpurtak
marcinpurtak approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@marcinpurtak marcinpurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

marcinpurtak
marcinpurtak approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@marcinpurtak marcinpurtak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Rafalz13
Rafalz13 requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update docstrings and fix typos.

viadot/sources/tm1.py Show resolved Hide resolved
viadot/sources/tm1.py Outdated Show resolved Hide resolved
viadot/sources/tm1.py Outdated Show resolved Hide resolved
viadot/sources/tm1.py Outdated Show resolved Hide resolved
viadot/tasks/tm1.py Show resolved Hide resolved
@angelika233 angelika233 requested a review from Rafalz13 November 13, 2023 13:55
@Rafalz13 Rafalz13 merged commit b3fac79 into dev Nov 13, 2023
3 checks passed
@trymzet trymzet deleted the tm1 branch March 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

@marcinpurtak marcinpurtak marcinpurtak approved these changes

@m-paz m-paz Awaiting requested review from m-paz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angelika233 @marcinpurtak @Rafalz13