don't overwrite name with login

dzcode-io · Oct 5, 2024 · d734351 · d734351
1 parent 0e0e463
commit d734351
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/api/src/digest/cron.ts b/api/src/digest/cron.ts
@@ -145,13 +145,16 @@ export class DigestCron {
             );
 
             for (const repoContributor of repoContributorsFiltered) {
-              const [{ id: contributorId }] = await this.contributorsRepository.upsert({
-                name: repoContributor.name || repoContributor.login,
+              const contributor = await this.githubService.getUser({
                 username: repoContributor.login,
-                url: repoContributor.html_url,
-                avatarUrl: repoContributor.avatar_url,
+              });
+              const [{ id: contributorId }] = await this.contributorsRepository.upsert({
+                name: contributor.name || contributor.login,
+                username: contributor.login,
+                url: contributor.html_url,
+                avatarUrl: contributor.avatar_url,
                 runId,
-                id: `${provider}-${repoContributor.login}`,
+                id: `${provider}-${contributor.login}`,
               });
 
               await this.contributorsRepository.upsertRelationWithRepository({

diff --git a/api/src/github/types.ts b/api/src/github/types.ts
@@ -2,13 +2,13 @@ import { GeneralResponse } from "src/app/types";
 
 interface GithubUser {
   login: string;
-  name: string;
+  name: string | null;
   html_url: string;
   avatar_url: string;
   type: "User" | "_other";
 }
 
-interface GithubRepositoryContributor extends GithubUser {
+interface GithubRepositoryContributor extends Omit<GithubUser, "name"> {
   contributions: number;
 }
 

diff --git a/web/src/pages/team/index.tsx b/web/src/pages/team/index.tsx
@@ -46,7 +46,7 @@ export default function Page(): JSX.Element {
             {contributorsList.map((contributor, contributorIndex) => (
               <Link
                 key={contributorIndex}
-                className="card bg-base-300 sm:max-w-60 w-full rounded-lg flex flex-row border-base-200 border-2 overflow-hidden"
+                className="card bg-base-300 w-full sm:max-w-52 rounded-lg flex flex-row border-base-200 border-2 overflow-hidden"
                 href={getContributorURL(contributor)}
               >
                 <img