-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Rust support #46
add Rust support #46
Conversation
6b14de6
to
6d19679
Compare
Needs a separate PR for publishing the crate appropriately (the file needs to be read as an absolute path from the crate itself) |
defeb73
to
89ed860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work as usual!
to summarize my points:
- let's use rust algebraic data types, to define the three levels of our nodes.
- let's follow the rest of the packages and transform our
/_data
folder into one JSON file, I built a quick PoC in Poc of generating_data.rs
from../_data
folder #47.- we can later modify the build script, so it generates actual structs that we store directly in the stack instead of the heap for ultimate performance, but that is for later, let's not optimize prematurely.
- let's do it how rustaceans do it, by being as idiomatic as possible.
My bad 😅 my java extension is working behind the scenes (I'll revert those java changes) |
10051c4
to
edf8df7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go 🚀
Description
Implements #44
See also #11
Type of change
Please delete options that are not relevant.