Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Rust support #46

Merged
merged 8 commits into from
Jan 5, 2024
Merged

add Rust support #46

merged 8 commits into from
Jan 5, 2024

Conversation

omdxp
Copy link
Member

@omdxp omdxp commented Jan 2, 2024

Description

  • First iteration to implement the Rust library for Kuliya.

Implements #44
See also #11

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Updated the dataset

@omdxp omdxp self-assigned this Jan 2, 2024
@omdxp omdxp linked an issue Jan 2, 2024 that may be closed by this pull request
@github-actions github-actions bot added the rust label Jan 2, 2024
@github-actions github-actions bot added the java Java related changes label Jan 2, 2024
@github-actions github-actions bot removed the java Java related changes label Jan 2, 2024
@omdxp omdxp requested a review from ZibanPirate January 2, 2024 20:14
@omdxp omdxp marked this pull request as ready for review January 2, 2024 20:14
@omdxp
Copy link
Member Author

omdxp commented Jan 2, 2024

Needs a separate PR for publishing the crate appropriately (the file needs to be read as an absolute path from the crate itself)

Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work as usual!

to summarize my points:

  • let's use rust algebraic data types, to define the three levels of our nodes.
  • let's follow the rest of the packages and transform our /_data folder into one JSON file, I built a quick PoC in Poc of generating _data.rs from ../_data folder #47.
    • we can later modify the build script, so it generates actual structs that we store directly in the stack instead of the heap for ultimate performance, but that is for later, let's not optimize prematurely.
  • let's do it how rustaceans do it, by being as idiomatic as possible.

rust/src/lib.rs Outdated Show resolved Hide resolved
rust/src/lib.rs Show resolved Hide resolved
rust/gen_data.rs Outdated Show resolved Hide resolved
@github-actions github-actions bot added the java Java related changes label Jan 5, 2024
@omdxp
Copy link
Member Author

omdxp commented Jan 5, 2024

My bad 😅 my java extension is working behind the scenes (I'll revert those java changes)

@github-actions github-actions bot removed the java Java related changes label Jan 5, 2024
@omdxp omdxp requested a review from ZibanPirate January 5, 2024 18:24
Copy link
Member

@ZibanPirate ZibanPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@omdxp omdxp merged commit 6ea5ec1 into main Jan 5, 2024
4 checks passed
@omdxp omdxp deleted the 44-add-rust-support branch January 5, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Add Rust support
2 participants