Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use const and match statement instead of json data #53

Merged
merged 1 commit into from
Jan 7, 2024
Merged

use const and match statement instead of json data #53

merged 1 commit into from
Jan 7, 2024

Conversation

ZibanPirate
Copy link
Member

  • now we build a rust file instead of cloning the data folder
  • now we use Rust match statement instead of file-system api
  • removed serde and serde_json

Type of change

  • refactoring

@ZibanPirate ZibanPirate self-assigned this Jan 7, 2024
@github-actions github-actions bot added the rust label Jan 7, 2024
@ZibanPirate ZibanPirate requested a review from omdxp January 7, 2024 19:08
omdxp
omdxp approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll be clearer when we add docs for all used functions

@ZibanPirate ZibanPirate merged commit a4948a2 into main Jan 7, 2024
4 checks passed
@ZibanPirate ZibanPirate deleted the chore/algebraic-data-types-implementation branch January 7, 2024 19:27
@omdxp omdxp mentioned this pull request Jan 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees

@ZibanPirate ZibanPirate

Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZibanPirate @omdxp