Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce TLS property #137

Closed
wants to merge 1 commit into from
Closed

Conversation

Yanpas
Copy link

@Yanpas Yanpas commented Nov 9, 2023

This option is intended for PROD environment where every access is mandatory to be encrypted

@dzmipt
Copy link
Owner

dzmipt commented Nov 10, 2023

(1) This functionality seems to override useTLS flag which is set up on per server connection. Which is odd (I don't have TLS for a server; but it is used)
(2) Also it is implemented for all connections. So if my list has PROD and not PROD connections, I get TLS set for all connections
(3) The config is not exposed to the Settings dialog.
There is a similar request. I want to have red background for all PROD connections. I can go through all my servers and put red color for all PROD connections which is not convenient.

May be we need to have a screen with overrides ?
based on Connection name and/or folder location, we want to have overrides for one of the parameters useTLS, authMethod, bgColor, user, password.

It is a little bit more complicated then you implemented. But it looks like more user friendly.

P.S. I saw you modified Netbeans ServerForm.form. Do you use Netbeans? I thought to remove all *.form and set up all UI forms manually.

@Yanpas
Copy link
Author

Yanpas commented Nov 10, 2023

I guess in order to generalize common settings for connections tags would be appropriate. That can be done along with moving server list to some separate json file (#109). So each connection will have only mandatory host and port. username, password, tls tick (we also have alternative auth method dropdown) and other things can be inherited from tag settings

Concerning form file - no, I don't use it. I've edited it just in case.

@dernasherbrezon your thoughts :)

@dernasherbrezon
Copy link

dernasherbrezon commented Nov 10, 2023

We're running kdb studio in the special "prod" mode where certain features like TLS enabled by default, cannot be turned off and intentionally not available for end-users. Otherwise they will untick TLS because it is failing and/or inconvenient.

However this all works in the very specific setup where we fully control client's configuration and do not allow client edit it.

@dzmipt
Copy link
Owner

dzmipt commented Nov 17, 2023

It looks you are after functionality to have a separate (centrally distributed) properties which couldn't be overridden form UI. From the implementation perspective, it could be a separate *.properties file which is assumed to be write-lock on the client machine.

However if you need enforce TLS, why can't you enforce this on the server side?

@Yanpas Yanpas closed this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants