Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduced string length for innodb 5.6 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NiklasSchmitt
Copy link

@NiklasSchmitt NiklasSchmitt commented May 27, 2022

error while installation:

{"reqId":"0YbMH1Fd40D73AzYk0fG","level":3,"time":"2022-05-27T21:57:32+00:00","remoteAddr":"185.66.193.120","user":"Niklas","app":"settings","method":"POST","url":"/settings/apps/enable","message":"could not enable apps","userAgent":"Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:100.0) Gecko/20100101 Firefox/100.0","version":"24.0.1.1","exception":{"Exception":"InvalidArgumentException","Message":"Column \"oc_reader_bookmarks\".\"content\" is type String, but exceeding the 4.000 length limit.","Code":0,"Trace":[{"file":"/var/www/html/lib/private/DB/MigrationService.php","line":461,"function":"ensureOracleConstraints","class":"OC\\DB\\MigrationService","type":"->","args":[{"__class__":"Doctrine\\DBAL\\Schema\\Schema"},{"__class__":"Doctrine\\DBAL\\Schema\\Schema"},3]},{"file":"/var/www/html/lib/private/DB/MigrationService.php","line":417,"function":"migrateSchemaOnly","class":"OC\\DB\\MigrationService","type":"->","args":["latest"]},{"file":"/var/www/html/lib/private/Installer.php","line":154,"function":"migrate","class":"OC\\DB\\MigrationService","type":"->","args":["latest",true]},{"file":"/var/www/html/apps/settings/lib/Controller/AppSettingsController.php","line":451,"function":"installApp","class":"OC\\Installer","type":"->","args":["epubreader"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":225,"function":"enableApps","class":"OCA\\Settings\\Controller\\AppSettingsController","type":"->","args":[["epubreader"],[]]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":133,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"enableApps"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":172,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Settings\\Controller\\AppSettingsController"},"enableApps"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":298,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Settings\\Controller\\AppSettingsController","enableApps",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"settings.AppSettings.enableApps"}]},{"file":"/var/www/html/lib/base.php","line":1023,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/settings/apps/enable"]},{"file":"/var/www/html/index.php","line":36,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/lib/private/DB/MigrationService.php","Line":613,"CustomMessage":"could not enable apps"}}

I've changed length of strings from 4096 back to 4000 for supporting a installation of this app on innodb 5.6 databases.
see here for reference: https://dev.mysql.com/doc/refman/5.6/en/innodb-limits.html

changed length from 4096 to 4000 for strings to install it on innodb 5.6
https://dev.mysql.com/doc/refman/5.6/en/innodb-limits.html
@NiklasSchmitt NiklasSchmitt changed the title database: fix string length fix: reduced string length for innodb 5.6 May 27, 2022
@fossil-free
Copy link

Could this pull request be merged? Installing ebookreader fails for me in our NC 24 with the error message:
"Column "oc_reader_bookmarks"."content" is type String, but exceeding the 4.000 length limit."
(I don't know whether we use an innodb database though).

@Emiliaaah
Copy link

I'm also asking for this to be merged. This seems to also fix the issue for me.

@DerBoki
Copy link

DerBoki commented Jul 13, 2022

Definitely fixed it for me today. Please merge this, so everybody can enjoy it in NC24. :)

@borekon
Copy link

borekon commented Nov 23, 2022

Developers are missing...

@markuman
Copy link

markuman commented Jan 3, 2023

@e-alfred do you have time to target this one?

devnoname120 pushed a commit to devnoname120/epubviewer that referenced this pull request Jul 30, 2023
Original PR: e-alfred#45

Change length from 4096 to 4000 for row size (e.g. strings) to make it work on InnoDB 5.6.
See: https://dev.mysql.com/doc/refman/5.6/en/innodb-limits.html

Fix the following error: `Column "oc_reader_bookmarks"."content" is type String, but exceeding the 4.000 length limit."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants