-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use QbMapper to replace the Mapper removed in nextcloud version 26.0.0 #48
Open
fcki1984
wants to merge
7
commits into
e-alfred:master
Choose a base branch
from
fcki1984:QBMapper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4d87d38
Update ReaderMapper.php
fcki1984 3ea4246
Update BookmarkMapper.php
fcki1984 4798977
Update PreferenceMapper.php
fcki1984 ec75971
Update PreferenceMapper.php
fcki1984 1ae0fad
Update BookmarkMapper.php
fcki1984 cc0b8fb
Update BookmarkMapper.php
fcki1984 1f0cd40
Update BookmarkMapper.php
fcki1984 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,6 +10,7 @@ | |||||
|
||||||
namespace OCA\Epubreader\Db; | ||||||
|
||||||
use OCP\DB\QueryBuilder\IQueryBuilder; | ||||||
use OCA\Epubreader\Utility\Time; | ||||||
use OCP\IDBConnection; | ||||||
|
||||||
|
@@ -29,22 +30,18 @@ public function __construct(IDBConnection $db, $UserId, Time $time) { | |||||
* @return array | ||||||
*/ | ||||||
public function get($scope, $fileId, $name=null) { | ||||||
if(!empty($name)) { | ||||||
$sql = "SELECT * FROM `*PREFIX*reader_prefs` WHERE `scope`=? AND `file_id`=? AND `user_id`=? AND `name`=?"; | ||||||
$args = array( | ||||||
$scope, | ||||||
$fileId, | ||||||
$this->userId, | ||||||
$name); | ||||||
} else { | ||||||
$sql = "SELECT * FROM `*PREFIX*reader_prefs` WHERE `scope`=? AND `file_id`=? AND `user_id`=?"; | ||||||
$args = array( | ||||||
$scope, | ||||||
$fileId, | ||||||
$this->userId); | ||||||
$query = $this->db->getQueryBuilder(); | ||||||
$query->select('*') | ||||||
->from($this->getTableName()) | ||||||
->where($query->expr()->eq('scope', $query->createNamedParameter($scope))) | ||||||
->andWhere($query->expr()->eq('file_id', $query->createNamedParameter($fileId))) | ||||||
->andWhere($query->expr()->eq('user_id', $query->createNamedParameter($this->userId))); | ||||||
|
||||||
if (!empty($name)) { | ||||||
$query->andWhere($query->expr()->eq('name', $query->createNamedParameter($name))); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
return $this->findEntities($sql, $args); | ||||||
return $this->findEntities($query); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
} | ||||||
|
||||||
/** | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.