Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and fix lint warnings #316

Merged
merged 10 commits into from
Jan 2, 2023
Merged

Update dependencies and fix lint warnings #316

merged 10 commits into from
Jan 2, 2023

Conversation

hollow
Copy link
Contributor

@hollow hollow commented Dec 27, 2022

  • update all dependencies
  • update netbox used in tests to 3.4.1
  • add pre-commit hooks for Markdown, YAML, shell scripts, etc
  • add GitHub Actions workflow for pre-commit
  • fix all linter errors and warnings

@fbreckle fbreckle merged commit 39fe490 into e-breuninger:master Jan 2, 2023
@fbreckle
Copy link
Collaborator

fbreckle commented Jan 2, 2023

Hi,

this MR was somewhat messy. Since I found the intention useful, I cleaned it up and split it in separate understandable commits. I removed the docs folder from all linters, because it is autogenerated. You updated to a too new version of the go-netbox library that incurred some changes with tags. I rolled back these changes.

@hollow
Copy link
Contributor Author

hollow commented Jan 2, 2023

@fbreckle Thanks! I agree that this PR escalated a bit. I wanted to update go-netbox (again) after fbreckle/go-netbox#26 has been merged, because it currently breaks my Terraform Cloud runs and I can only run my netbox provider fork locally.

What do I need to do for tags in order to update go-netbox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollow @fbreckle